Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth2 documentation update #356

Merged
merged 4 commits into from
Mar 28, 2016
Merged

oauth2 documentation update #356

merged 4 commits into from
Mar 28, 2016

Conversation

thebestmensch
Copy link
Contributor

Oauth2client version 2.0.0 removed SignedJwtAssertCredentials, which is referenced in your authorization readme. I've updated OAuth2.rst to now properly describe how to authorize with oauth2client 2.0.0 using a replacement method, ServiceAccountCredentials.

@thebestmensch
oauth2 documentation update
94b2491 
FIX: OAuth2.rst now properly describes how to get set up with
oauth2client v2.0.0
@thebestmensch thebestmensch mentioned this pull request Feb 27, 2016
Closed
@msuozzo
Copy link
Collaborator

msuozzo commented Feb 28, 2016

Thanks for the PR! A few notes:

  • You can remove the import json because it's no longer used
  • Would you mind adding a section for oath2client's previous semantics? The latest version might not be universally supported yet so we should keep a note of the previous way of doing things.

Thanks again!

@thebestmensch
Copy link
Contributor Author

@vagelim Thanks for the catch!
@msuozzo Makes sense, I've added the section for oauth2client < 2.0.0

@thebestmensch thebestmensch mentioned this pull request Feb 28, 2016
Closed
@thebestmensch
Copy link
Contributor Author

CI will pass when fix for issue #363 is integrated.

vmahedia added a commit to vmahedia/gspread that referenced this pull request Mar 16, 2016
@vmahedia
Remove deprecated method to read credentials - closes burnash#343, cl…
2be0a3c 
…oses burnash#357, closes burnash#356

SignedJwtAssertionCredentials is deprecated, replaced that with
new method with reads credentials directly from the file.

googleapis/oauth2client#401
@msuozzo
Copy link
Collaborator

msuozzo commented Mar 17, 2016

Fantastic! Last nit: The most up-to-date instructions should come first and the old ones should come second prefaced with a note like "For older versions of the oauth2client (< 2.0.0):"

Thanks again!

@thebestmensch
Copy link
Contributor Author

@msuozzo thanks, updated!

@msuozzo msuozzo merged commit 4c80deb into burnash:master Mar 28, 2016
@danielhedblom danielhedblom mentioned this pull request Apr 8, 2016
Open
@msuozzo msuozzo mentioned this pull request Apr 17, 2016
Closed
@blais blais mentioned this pull request May 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thebestmensch @msuozzo